Home / Companies / Hasura / Blog / Post Details
Content Deep Dive

Improving Hasura's Internal PR Review process

Blog post from Hasura

Post Details
Company
Date Published
Author
Stefano Magni
Word Count
2,114
Language
English
Hacker News Points
-
Summary

In 2022, Hasura's Pull Requests (PR) remained open on average for seven days. This slow PR review process was problematic as it delayed the Software Development Life Cycle and required continuous back-and-forth between authors and reviewers. To address this issue, a dedicated internal Working Group was formed to investigate the human aspects of the problem. The group identified several root causes such as missing or insufficiently detailed PR descriptions, large PRs, lack of ownership, notifications going unnoticed, and timezone overlaps. They also suggested best practices for each issue, including writing detailed PR descriptions, creating reasonably-sized PRs, assigning specific people to review a PR, and enabling GitHub real-time alerts. The Working Group will continue monitoring the progress and adoption of these best practices over the next few months.